Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code quality improvements
  1. … 22 more files in changeset.
Gradle migration from Maven. Updated everything.
  1. … 51 more files in changeset.
I've moved the VertexRenderer's methods into the VertexView and the moved the state of the game from the VertexView to State and MainActivity.

#FALLDOWN-64 - Review the VertexRenderer and VertexView classes

  1. … 19 more files in changeset.
I've moved the LevelLoader from the model to the dao package.
  1. … 7 more files in changeset.
I've integrated the IabHelper to the BaseActivity class.

#FALLDOWN-60 - Integrate the IabHelper

  1. … 13 more files in changeset.
I've refactored the SelectLevelActivity, create a State class, cleaned up the VertexView and the VertexRenderer class, moved string literals from code to strings.xml.

#FALLDOWN-45 - Sonar Issue #24e3b713-ec40-4a30-9ce1-5fb45e19109f - Ncss Method Count

#FALLDOWN-46 - Sonar Issue #6ebb8217-97d8-45ea-933b-0438bebc4e10 - Methods should not be too complex

#FALLDOWN-53 - Sonar Issue #a5d23d6c-58ed-450c-a6ff-7fdf93262e7c - Methods should not be too complex

  1. … 13 more files in changeset.
I've created a named inner class instead of anonymous inner class.

#FALLDOWN-52 - Sonar Issue #7e1c1571-7683-4acf-81f8-8e8454d3a2c6 - Anon Inner Length

  1. … 1 more file in changeset.
I've improved code coverage.
    • -0
    • +60
    ./javaforum/android/falldown/model/LevelHistoryNGTest.java
    • -0
    • +136
    ./javaforum/android/falldown/model/LevelNGTest.java
  1. … 1 more file in changeset.
I've created a Point inner class in the PlateModel and removed PointF from modified classes.

Task #FALLDOWN-33 - Remove android.graphics.PointF dependency

    • -0
    • +243
    ./javaforum/android/falldown/model/PlateFactoryNGTest.java
    • -0
    • +29
    ./javaforum/android/falldown/model/PlateModelNGTest.java
    • -0
    • +143
    ./javaforum/android/falldown/model/VertexModelNGTest.java
  1. … 3 more files in changeset.
I've refactored some classes... Level data has been moved out to property file from Java code. I've created a LevelLoader class, and modified a 3D models of tube and plates.

Task #FALLDOWN-14 - Sonar Issue #0be2f4ca-add6-42b6-9590-417da78139a9

  1. … 14 more files in changeset.
I've modified these classes for improve code quality.

#FALLDOWN-22 - Sonar Issue #86eba351-1ba1-4083-9ebe-b5da2acbff00 - Parameter Assignment

#FALLDOWN-23 - Sonar Issue #e27dd105-cf5d-410a-87fa-31f43aef1ddb - Parameter Assignment

  1. … 1 more file in changeset.
I've modified the affected rows in these classes.

Task #FALLDOWN-21 - Sonar Issue #7f61030f-c220-4be4-a961-062ee6cb07bf - Magic Number

  1. … 1 more file in changeset.
I've refactored the TubeVertexModel class.

Task #FALLDOWN-18 - Code quality improvement

    • -0
    • +129
    ./javaforum/android/falldown/model/TubeVertexModelNGTest.java
  1. … 2 more files in changeset.