javaforum

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code quality improvements
    • -1
    • +1
    ./android/falldown/dao/LevelLoader.java
    • -1
    • +1
    ./android/falldown/opengl/VertexView.java
    • -17
    • +9
    ./android/falldown/BaseActivity.java
    • -1
    • +0
    ./android/falldown/HowToPlayActivity.java
    • -1
    • +1
    ./android/falldown/model/Preferences.java
  1. … 15 more files in changeset.
Gradle migration from Maven. Updated everything.
    • -29
    • +10
    ./android/falldown/HowToPlayActivity.java
    • -300
    • +118
    ./android/falldown/SelectLevelActivity.java
    • -39
    • +25
    ./android/falldown/dao/LevelLoader.java
    • -36
    • +15
    ./android/falldown/opengl/VertexView.java
    • -138
    • +16
    ./android/falldown/model/Preferences.java
    • -169
    • +0
    ./android/falldown/ProfileActivity.java
    • -60
    • +25
    ./android/falldown/MainActivity.java
    • -118
    • +37
    ./android/falldown/BaseActivity.java
    • -82
    • +0
    ./android/commons/ScoreLoopObserver.java
    • -120
    • +0
    ./android/commons/GoogleAdListener.java
    • -82
    • +0
    ./android/commons/FacebookConnectStatusListener.java
  1. … 37 more files in changeset.
Turned the legacy app to mainstream because of the Google approved the In-app billing from Hungary.

#FALLDOWN-67 - Pre-release tasks

    • -1
    • +0
    ./android/falldown/ProfileActivity.java
    • -1
    • +1
    ./android/falldown/opengl/VertexView.java
    • -1
    • +1
    ./android/commons/ScoreLoopObserver.java
    • -1
    • +0
    ./android/falldown/HowToPlayActivity.java
  1. … 5 more files in changeset.
Code quality improvements. Enabled next level bug.

#FALLDOWN-66 - Minor code quality improvements

#FALLDOWN-68 - Eliminate level finishing bug

    • -19
    • +35
    ./android/falldown/MainActivity.java
  1. … 1 more file in changeset.
Fixed the missing last tube.

#FALLDOWN-58 - Pre-release tasks

    • -1
    • +1
    ./android/falldown/opengl/VertexView.java
Source code quality fixes.

#FALLDOWN-58 - Pre-release tasks

    • -131
    • +162
    ./android/falldown/MainActivity.java
I've implemented the "five star" per level.

#FALLDOWN-65 - Five star result

    • -0
    • +23
    ./android/falldown/model/State.java
    • -1
    • +45
    ./android/falldown/MainActivity.java
  1. … 4 more files in changeset.
I've moved the VertexRenderer's methods into the VertexView and the moved the state of the game from the VertexView to State and MainActivity.

#FALLDOWN-64 - Review the VertexRenderer and VertexView classes

    • -368
    • +0
    ./android/falldown/opengl/VertexRenderer.java
    • -84
    • +22
    ./android/falldown/model/PlateModel.java
    • -6
    • +31
    ./android/falldown/BaseActivity.java
    • -46
    • +227
    ./android/falldown/opengl/VertexView.java
    • -19
    • +3
    ./android/falldown/model/LevelHistory.java
    • -65
    • +126
    ./android/falldown/MainActivity.java
    • -0
    • +117
    ./android/falldown/model/Point.java
    • -4
    • +138
    ./android/falldown/model/State.java
  1. … 12 more files in changeset.
I've added animated 'AdFree' button and set event of this button to purchase the 'Ad Remover' product. The state of the purchase saved in the Preferences and the advertisements appears only when the adFree preference is false.

#FALLDOWN-62 - Implement AdFree purchase

    • -0
    • +21
    ./android/falldown/BaseActivity.java
  1. … 2 more files in changeset.
I've moved the LevelLoader from the model to the dao package.
    • -0
    • +198
    ./android/falldown/dao/LevelLoader.java
    • -291
    • +0
    ./android/falldown/model/LevelLoader.java
    • -10
    • +1
    ./android/falldown/model/PlateFactory.java
    • -0
    • +100
    ./android/falldown/model/Plates.java
  1. … 3 more files in changeset.
I've added the 'adFree' and the 'vouchers' variables to the Preferences.

#FALLDOWN-61 - Add variables to Preferences

    • -1
    • +51
    ./android/falldown/model/Preferences.java
I've integrated the IabHelper to the BaseActivity class.

#FALLDOWN-60 - Integrate the IabHelper

    • -0
    • +28
    ./android/falldown/BaseActivity.java
  1. … 10 more files in changeset.
I've refactored the onCreate method in the SelectLevelActivity class.

#FALLDOWN-49 - Sonar Issue #1d5f40e3-99c9-477e-8622-8d4b4cd86b69 - Methods should not be too complex

I've refactored the SelectLevelActivity, create a State class, cleaned up the VertexView and the VertexRenderer class, moved string literals from code to strings.xml.

#FALLDOWN-45 - Sonar Issue #24e3b713-ec40-4a30-9ce1-5fb45e19109f - Ncss Method Count

#FALLDOWN-46 - Sonar Issue #6ebb8217-97d8-45ea-933b-0438bebc4e10 - Methods should not be too complex

#FALLDOWN-53 - Sonar Issue #a5d23d6c-58ed-450c-a6ff-7fdf93262e7c - Methods should not be too complex

    • -3
    • +3
    ./android/falldown/model/LevelLoader.java
    • -10
    • +10
    ./android/falldown/model/Level.java
    • -57
    • +2
    ./android/falldown/opengl/VertexView.java
    • -14
    • +5
    ./android/falldown/model/Preferences.java
    • -114
    • +37
    ./android/falldown/opengl/VertexRenderer.java
    • -183
    • +131
    ./android/falldown/SelectLevelActivity.java
    • -41
    • +34
    ./android/falldown/MainActivity.java
    • -0
    • +100
    ./android/falldown/model/State.java
  1. … 6 more files in changeset.
I've modified the compute of scores in the SelectLevelActivity class.

#FALLDOWN-48 - Sonar Issue #87ca05ab-ec0c-4853-82c6-b8e6be3acd65 - Avoid Array Loops

I've refactored the onResume method of SelectLevelActivity class.

#FALLDOWN-48 - Sonar Issue #87ca05ab-ec0c-4853-82c6-b8e6be3acd65 - Avoid Array Loops

I've refactored the onCreate method of SelectLevelActivity class and moved some classes to other package.

#FALLDOWN-42 - Sonar Issue #94ed3ca8-c4e2-4e68-a5f2-cc10a668602e - Ncss Method Count

    • -158
    • +0
    ./android/falldown/VertexView.java
    • -0
    • +82
    ./android/commons/FacebookConnectStatusListener.java
    • -113
    • +0
    ./android/falldown/FacebookAsyncRunnerListener.java
    • -82
    • +0
    ./android/falldown/FacebookUpdateStatusListener.java
    • -0
    • +287
    ./android/falldown/model/Preferences.java
    • -0
    • +82
    ./android/commons/FacebookUpdateStatusListener.java
    • -0
    • +113
    ./android/commons/FacebookAsyncRunnerListener.java
    • -82
    • +0
    ./android/falldown/FacebookConnectStatusListener.java
    • -445
    • +0
    ./android/falldown/VertexRenderer.java
    • -0
    • +445
    ./android/falldown/opengl/VertexRenderer.java
    • -287
    • +0
    ./android/falldown/Preferences.java
    • -51
    • +119
    ./android/falldown/ProfileActivity.java
    • -0
    • +158
    ./android/falldown/opengl/VertexView.java
I've refactored the SelectLevelActivity class (and created some other classes), removed MessageBox, removed the texture resolution (because of current devices capability), extended the BaseActivity functionality, created Preferences class.

#FALLDOWN-42 - Sonar Issue #94ed3ca8-c4e2-4e68-a5f2-cc10a668602e - Ncss Method Count

#FALLDOWN-45 - Sonar Issue #24e3b713-ec40-4a30-9ce1-5fb45e19109f - Ncss Method Count

#FALLDOWN-46 - Sonar Issue #6ebb8217-97d8-45ea-933b-0438bebc4e10 - Methods should not be too complex

#FALLDOWN-53 - Sonar Issue #a5d23d6c-58ed-450c-a6ff-7fdf93262e7c - Methods should not be too complex

    • -0
    • +82
    ./android/falldown/FacebookUpdateStatusListener.java
    • -25
    • +5
    ./android/falldown/ProfileActivity.java
    • -0
    • +287
    ./android/falldown/Preferences.java
    • -29
    • +3
    ./android/falldown/HowToPlayActivity.java
    • -290
    • +200
    ./android/falldown/SelectLevelActivity.java
    • -75
    • +17
    ./android/falldown/MainActivity.java
    • -107
    • +0
    ./android/commons/MessageBox.java
    • -13
    • +11
    ./android/falldown/VertexRenderer.java
    • -4
    • +29
    ./android/falldown/BaseActivity.java
  1. … 7 more files in changeset.
I've refactored the onClick method in the SelectLevelActivity class.

#FALLDOWN-49 - Sonar Issue #1d5f40e3-99c9-477e-8622-8d4b4cd86b69 - Methods should not be too complex

#FALLDOWN-50 - Sonar Issue #2575c77b-02c5-4251-b5b1-614b3e610ac9 - Ncss Method Count

    • -28
    • +19
    ./android/falldown/FacebookAsyncRunnerListener.java
    • -0
    • +171
    ./android/falldown/BaseActivity.java
    • -173
    • +142
    ./android/falldown/SelectLevelActivity.java
    • -0
    • +82
    ./android/falldown/FacebookConnectStatusListener.java
I've moved the AsyncRunnerListener inner class out to FacebookAsyncRunnerListener class and eliminated the literals.

#FALLDOWN-54 - Sonar Issue #61db3e04-a73e-4734-96fe-cf4d093bfa81 - Avoid Duplicate Literals

    • -0
    • +122
    ./android/falldown/FacebookAsyncRunnerListener.java
  1. … 2 more files in changeset.
I've created a named inner class instead of anonymous inner class.

#FALLDOWN-52 - Sonar Issue #7e1c1571-7683-4acf-81f8-8e8454d3a2c6 - Anon Inner Length

  1. … 2 more files in changeset.
I've reorganized the constant "facebook".

#FALLDOWN-51 - Sonar Issue #16f6bf16-7151-4f89-9282-4cfd11ab2f2f - Avoid Duplicate Literals

I've reorganized the naming of levels.

#FALLDOWN-47 - Sonar Issue #8f6eea05-2f26-4cfb-b108-9cc24d079457 - Avoid Duplicate Literals

    • -1
    • +17
    ./android/falldown/model/LevelLoader.java
I've renamed the variable.

#FALLDOWN-44 - Sonar Issue #6df7fc67-335e-476e-9049-1571e7951986 - Local variable and method parameter names should comply with a naming convention

I've reorganized the dependencies in the pom.xml and modified the version number in the AndroidManifest.xml.

I've added a logger line with error level.

#FALLDOWN-43 - Sonar Issue #f4fe49ba-8b14-4ef1-8e5d-761faa72a2d8 - Nested blocks of code should not be left empty

  1. … 2 more files in changeset.
I've moved the GoogleAdListener out from Falldown's scope and added localized text instead of native code.

#FALLDOWN-19 - Code quality improvement

    • -0
    • +120
    ./android/commons/GoogleAdListener.java
    • -7
    • +40
    ./android/commons/ScoreLoopObserver.java
    • -2
    • +2
    ./android/falldown/HowToPlayActivity.java
    • -87
    • +0
    ./android/falldown/GoogleAdListener.java
  1. … 4 more files in changeset.
I've added a 'Coming soon' toast to click event of 'adFree' button.

#FALLDOWN-41 - Ad free icon

I've replaced the old 'default.keystore' file to the application specific 'falldown3d.keystore' file (with real strong password).

I've modified the version number from '1.4.4' to '1.4.5-SNAPSHOT' and refactored the version number from 'strings.xml' to SelectLevelActivity class.

I've replaced the package identifier from 'hu.javaforum.android.falldown' to ''hu.javaforum.android.falldown3d'.

I've replaced the old Analytics ID to the new one.

I've added an 'Ad free' icon.

#FALLDOWN-19 - Code quality improvement

# FALLDOWN-38 - Pre release tasks

#FALLDOWN-41 - Ad free icon

    • -0
    • +1
    ./android/falldown/ProfileActivity.java
    • -0
    • +1
    ./android/falldown/HowToPlayActivity.java
  1. … 11 more files in changeset.
I've removed the redundant final keyword.

#FALLDOWN-19 - Code quality improvement

    • -1
    • +1
    ./android/falldown/HowToPlayActivity.java
Replaced the mispelled "Vortex" to "Vertex".

#FALLDOWN-19 - Code quality improvement

    • -13
    • +13
    ./android/falldown/MainActivity.java
    • -523
    • +0
    ./android/falldown/VortexRenderer.java
    • -0
    • +447
    ./android/falldown/VertexRenderer.java
    • -156
    • +0
    ./android/falldown/VortexView.java
    • -0
    • +157
    ./android/falldown/VertexView.java
  1. … 1 more file in changeset.